Replace npm ip package with ip-address #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: GHSA-2p57-rm9w-gvfp The https://github.com/indutny/node-ip project has been officially archived and is no longer actively maintained. Switching to ip-address is recommended by indutny/node-ip#150 and avoids ongoing security issues with the identification of public vs. private IP addresses in "ip".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 52.12% 52.20% +0.07%
==========================================
Files 100 100
Lines 5590 5590
==========================================
+ Hits 2914 2918 +4
+ Misses 2429 2427 -2
+ Partials 247 245 -2 ☔ View full report in Codecov by Sentry. |
jraddaoui
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: GHSA-2p57-rm9w-gvfp
The https://github.com/indutny/node-ip project has been officially archived and is no longer actively maintained. Switching to ip-address is recommended by indutny/node-ip#150 and avoids ongoing security issues with the identification of public vs. private IP addresses in "ip".