Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an SFTP package #737

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add an SFTP package #737

merged 1 commit into from
Nov 7, 2023

Conversation

djjuhasz
Copy link
Collaborator

  • Add an SFTP service definition
  • Implement an SFTP upload service method using native Go SSH and SFTP packages
  • Add SFTP configuration with some default values
  • Generate a service mock with mockgen
  • Add tests against a test SFTP server

@djjuhasz djjuhasz requested a review from sevein October 18, 2023 01:03
@djjuhasz djjuhasz force-pushed the dev/upload-transfer-to-am branch 4 times, most recently from 88bafda to 4014254 Compare October 18, 2023 18:04
@djjuhasz
Copy link
Collaborator Author

@sevein CI is passing now, so this is ready to review.

@djjuhasz djjuhasz force-pushed the dev/upload-transfer-to-am branch from 4014254 to ad179f9 Compare October 18, 2023 18:26
sevein
sevein requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback, I had to stop half-way through but will continue later.

internal/sftp/config.go Outdated Show resolved Hide resolved
internal/sftp/goclient.go Outdated Show resolved Hide resolved
internal/sftp/goclient.go Outdated Show resolved Hide resolved
internal/sftp/goclient.go Show resolved Hide resolved
internal/sftp/service.go Outdated Show resolved Hide resolved
sevein
sevein requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions, all minor.

internal/sftp/ssh.go Outdated Show resolved Hide resolved
internal/sftp/goclient.go Outdated Show resolved Hide resolved
internal/sftp/service.go Outdated Show resolved Hide resolved
internal/sftp/ssh.go Show resolved Hide resolved
internal/sftp/goclient_test.go Outdated Show resolved Hide resolved
internal/sftp/goclient_test.go Outdated Show resolved Hide resolved
internal/sftp/goclient_test.go Show resolved Hide resolved
internal/sftp/goclient_test.go Outdated Show resolved Hide resolved
@djjuhasz djjuhasz force-pushed the dev/upload-transfer-to-am branch 5 times, most recently from 46b118e to 59e2333 Compare November 3, 2023 16:47
@djjuhasz djjuhasz requested a review from sevein November 3, 2023 20:15
@djjuhasz djjuhasz force-pushed the dev/upload-transfer-to-am branch 2 times, most recently from 84503ec to 390c986 Compare November 3, 2023 20:21
sevein
sevein approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor observations that shouldn't block you for merging. 👍

internal/sftp/goclient.go Outdated Show resolved Hide resolved
internal/sftp/goclient_test.go Outdated Show resolved Hide resolved
internal/sftp/goclient_test.go Outdated Show resolved Hide resolved
@djjuhasz
Add an SFTP client package
83e2414 
- Add an SFTP client interface definition
- Implement an SFTP client upload method using native Go SSH and SFTP
  packages
- Add SFTP configuration with some default values
- Generate a client mock with mockgen
- Add SFTP client tests against a test SFTP server
@djjuhasz djjuhasz force-pushed the dev/upload-transfer-to-am branch from 53e3241 to 83e2414 Compare November 7, 2023 16:34
@djjuhasz djjuhasz merged commit 01af95d into main Nov 7, 2023
8 checks passed
@djjuhasz djjuhasz deleted the dev/upload-transfer-to-am branch November 7, 2023 17:33
@sevein sevein mentioned this pull request Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevein sevein sevein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djjuhasz @sevein