Skip to content

Commit

Permalink
Merge pull request atosatto#33 from SuperQ/fix_travis
Browse files Browse the repository at this point in the history
Fix Travis errors.
  • Loading branch information
SuperQ authored Jul 4, 2019
2 parents 046e95d + 796f703 commit 76a2df8
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 30 deletions.
5 changes: 2 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ services:

env:
matrix:
- ANSIBLE=2.4
- ANSIBLE=2.5
- ANSIBLE=2.6
- ANSIBLE=2.7
- ANSIBLE=2.8

# Install tox
install:
Expand Down
2 changes: 1 addition & 1 deletion meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ galaxy_info:
- system
- minio
- storage
- object-storage
- objectstorage
- s3

dependencies: []
2 changes: 1 addition & 1 deletion molecule/alternative/tests/test_minio_alternative.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


@pytest.fixture()
def AnsibleDefaults(Ansible):
def AnsibleDefaults():
with open("../../defaults/main.yml", 'r') as stream:
return yaml.load(stream)

Expand Down
2 changes: 1 addition & 1 deletion molecule/cluster/tests/test_minio_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


@pytest.fixture()
def AnsibleDefaults(Ansible):
def AnsibleDefaults():
with open("../../defaults/main.yml", 'r') as stream:
return yaml.load(stream)

Expand Down
2 changes: 1 addition & 1 deletion molecule/default/tests/test_minio_default.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


@pytest.fixture()
def AnsibleDefaults(Ansible):
def AnsibleDefaults():
with open("../../defaults/main.yml", 'r') as stream:
return yaml.load(stream)

Expand Down
6 changes: 3 additions & 3 deletions tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---

- name: Add sni support to legacy python installations
include: python_sni.yml
include_tasks: python_sni.yml
when:
- ansible_os_family == 'Debian'
- ansible_python_version is version_compare('2.6.0', '>=')
- ansible_python_version is version_compare('2.7.9', '<')

- include: install-server.yml
- include_tasks: install-server.yml
when: minio_install_server

- include: install-client.yml
- include_tasks: install-client.yml
when: minio_install_client
20 changes: 9 additions & 11 deletions tasks/python_sni.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,28 @@

- name: install python-pip and SNI support packages
package:
name: "{{ item }}"
name:
- python-pip
- python-dev
- libssl-dev
- libffi-dev
state: present
register: _install_python_packages
until: _install_python_packages is succeeded
retries: 5
delay: 2
with_items:
- python-pip
- python-dev
- libssl-dev
- libffi-dev

# There extra pip dependencies are needed to add SSL SNI support to
# Python version prior to 2.7.9. SNI support is needed by the Ansible
# get_url module in server.yml and client.yml.
- name: install the Python SNI python-pip dependencies.
pip:
name: "{{ item }}"
name:
- pyopenssl
- ndg-httpsclient
- pyasn1
state: present
register: _install_pip_packages
until: _install_pip_packages is succeeded
retries: 5
delay: 2
with_items:
- pyopenssl
- ndg-httpsclient
- pyasn1
14 changes: 5 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,22 +1,18 @@
[tox]
minversion = 1.8
envlist = py{27}-ansible{23,24,25,26}
envlist = py{27}-ansible{27,28}
skipsdist = true

[travis:env]
ANSIBLE=
2.3: ansible23
2.4: ansible24
2.5: ansible25
2.6: ansible26
2.7: ansible27
2.8: ansible28

[testenv]
passenv = *
deps =
-rtest-requirements.txt
ansible23: ansible<2.4
ansible24: ansible<2.5
ansible25: ansible<2.6
ansible26: ansible<2.7
ansible27: ansible<2.8
ansible28: ansible<2.9
commands =
{posargs:molecule test --all --destroy always}

0 comments on commit 76a2df8

Please sign in to comment.