Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nm/readme #20

Merged
merged 17 commits into from
Mar 13, 2024
Merged

fix: nm/readme #20

merged 17 commits into from
Mar 13, 2024

Conversation

TomDarmon
Copy link
Contributor

Description of the goal of the PR

Changes this PR introduces (fill it before implementation)

  • [ ]

Checklist before requesting a review

  • The CI pipeline passes
  • I have typed my code
  • I have created / updated the docstrings
  • I have updated the README, if relevant
  • I have updated the requirements, if relevant
  • I have tested my code

Copy link
Contributor Author

@TomDarmon TomDarmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour le premier jet.

J'ai fait quelques commentaires sur ce qu'il faut reprendre

Faut garder en tête qju'un readme c'est un point d'entrée sur le repo, il faut mettre le strict minimum dont a besoin un utilisateur pour commencer à dev.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TomDarmon TomDarmon changed the title Feat/nm/readme fix: nm/readme Mar 13, 2024
@TomDarmon TomDarmon merged commit 7ec1476 into dev Mar 13, 2024
1 check passed
@TomDarmon TomDarmon deleted the feat/nm/readme branch March 13, 2024 10:25
nmathieufact added a commit that referenced this pull request Mar 14, 2024
Co-authored-by: Nicolas <nicolas.mathieu@artefact.com>
Co-authored-by: Nicolas Mathieu <81897925+nmathieufact@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants