feat(jsx): normalize class attribute #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
a7e468f to
447e759
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
447e759 to
913f694
Compare
kasperskei
commented
Oct 15, 2024
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
913f694 to
1681ced
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
f64a1a8 to
5936224
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
5936224 to
04fa070
Compare
artalar
reviewed
Oct 22, 2024
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
d9f7a66 to
1497a4b
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
1497a4b to
d9daa8a
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
d9daa8a to
30c7351
Compare
Akiyamka
reviewed
Oct 23, 2024
| null, | ||
| undefined, | ||
| {}, | ||
| [], |
There was a problem hiding this comment.
It's a bit inconsistent, that we treat {} and []
In js world they truly, and in objects of this lib - too.
Akiyamka
reviewed
Oct 23, 2024
Akiyamka
reviewed
Oct 23, 2024
artalar
requested changes
Oct 23, 2024
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
30c7351 to
e14ffda
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
e14ffda to
b21cede
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
b21cede to
7ed1ffd
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
7ed1ffd to
7753221
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
7753221 to
d93d4bc
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
d93d4bc to
9edf09b
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
9edf09b to
497fe41
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
497fe41 to
9a35907
Compare
artalar
reviewed
Oct 24, 2024
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
9a35907 to
4fab70f
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
4fab70f to
0fc94d8
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
0fc94d8 to
2e89b99
Compare
artalar
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class binding like vue.js.