Liambly/atc ua generalization #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(elimination of Apple Watch base class)
ziggythehamster
requested changes
Dec 14, 2022
ziggythehamster
approved these changes
Dec 15, 2022
hungyunliao
approved these changes
Dec 15, 2022
corrected spelling Co-authored-by: Hung-Yun Liao <hungyunliao@gmail.com>
…agent into liambly/atc-ua-generalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits apart what was previously in the
Apple Watchmodule into two browsers:Pod2WatchandAirTrafficFramework& removes the AppleWatch base class.The
AirTrafficFrameworkbrowser implementation was previously specific to Apple Watch. Since theatc/*UserAgent (AirTrafficFramework) is not specific to Apple Watch, this has now been generalized in an effort to additionally detect iOS and macOS OSes & their relevant platforms.