Fix error in package script for (Arch) Linux #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glubsy
commented
Jul 24, 2020
•
glubsy
commented
- While packaging, the "build/help" and "build/locale" directories are not found.
- Work around the issue with try/except statements.
- This probably affects packaging for other distributions as well.
glubsy
force-pushed
the
fix_package_script
branch
from
46093d3 to
f19b5d6
Compare
* While packaging, the "build/help" and "build/locale" directories are not found. * Work around the issue with try/except statements.
* Just like the Windows package function counterpart, better abort building the package if the help and locale files have not been build instead of ignoring the error
|
This seems alright as it is now, just as a reference if the help is not built then the offline help will not be available. One thing that could be changed here is the error messages could include how to build these |
|
Good thinking, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.