Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dupes Only view is not updated after Re-Prioritize Results #757

Closed
robertocaldas opened this issue Jan 2, 2021 · 2 comments · Fixed by #910
Closed

Dupes Only view is not updated after Re-Prioritize Results #757

robertocaldas opened this issue Jan 2, 2021 · 2 comments · Fixed by #910
Labels
bug Bug reports.

Comments

@robertocaldas
Copy link

robertocaldas commented Jan 2, 2021 •
edited
Loading

Describe the bug

After using Re-Prioritize Results, the Dupes Only view shows References among with other Dupes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Re-Prioritize Results, use the tool in a way that some duplicates are promoted to reference (I used "folder" criteria);
  2. Click the "Dupes Only" button.

Expected behavior
I would expect to only see duplicates in this view but I see references too. I shouldn't be seeing any blue results in this view.
Note: Mark All still works fine.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS 10.15.7
  • Version 4.0.3

Additional context
Nah
@robertocaldas robertocaldas added the bug Bug reports. label Jan 2, 2021
@glubsy
Copy link
Contributor

glubsy commented Jan 2, 2021

Thanks for the report, I can reproduce this on more recent versions too. Will need some investigations.

glubsy added a commit to glubsy/dupeguru that referenced this issue Jun 22, 2021
@glubsy
Fix refs appearing in dupes-only view
a51f263 
* Some refs appeared in the dupes-only view after a re-prioritization was done a second time.
* It seems the core.Results.__dupes list was not properly updated whenever core.app.Dupeguru.reprioritize_groups() -> core.Results.sort_dupes() was called.
When a re-prioritization is done, some refs became dupe, and some dupes became ref in their place. So we need to update the new state of the internal list of dupes kept by the Results object, instead of relying on the outdated cached one.
* Fix arsenetar#757.
@glubsy glubsy mentioned this issue Jun 22, 2021
Merged
@glubsy
Copy link
Contributor

glubsy commented Jun 22, 2021

Some additional notes for the record:

  • This never occurs the first time a re-prioritize action is triggered, only starts happening after the second one.
  • Applying a filter (with the top-right line edit box) clears out the erroneous references from the "dupe-only" view.

I believe I have fixed the issue in #910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug reports.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix refs appearing in dupes-only view glubsy/dupeguru
2 participants
@robertocaldas @glubsy