Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple errors of the same kind #449

Closed
Quantum00 opened this issue Oct 7, 2017 · 7 comments
Closed

Multiple errors of the same kind #449

Quantum00 opened this issue Oct 7, 2017 · 7 comments
Assignees
Labels
bug Bug reports. Windows Related to running on Windows.

Comments

@Quantum00
Copy link

Quantum00 commented Oct 7, 2017

There is a whole lot of this error popping up as soon as a normal scan is finished

Application Name: dupeGuru
Version: 4.0.3

Traceback (most recent call last):
File "C:\Users\arsen\github\dupeguru\hscommon\gui\progress_window.py", line 96, in pulse
File "C:\Users\arsen\github\dupeguru\qtlib\progress_window.py", line 44, in close
AttributeError: 'ProgressWindow' object has no attribute '_timer'

It apperas: C:\Users\arsen\ is hardcoded? There is no such directory on my pc.
Using Windows 10.

@arsenetar
Copy link
Owner

The paths reported in the Traceback are based on the location of the files before they were packaged via cx_Freeze. Those files all are stored as .pyc files in the python35.zip that is distributed with the application. I have not found a way to change that output, "C:\Users\arsen\github\dupeguru" is the base path in this case which the following path exists in the zip file at the installed location (as .pyc not .py).

I have run both the x64 and x32 versions on multiple computers (all x64) under both windows 10 and 7. Did you install it "for all users" or just for "yourself"? Also are you using the x64 or x32 version?

If I understand this correctly, to reproduce:

  1. Launch dupeGuru
  2. Select a folder and initiate a scan (progress window pops up)
  3. Scan completes (progress window closes)
  4. Error pops up (once per scan? or is this repeated several times?)

I currently can not reproduce it on my machines here, but looking into what could cause it.

@arsenetar arsenetar added the Windows Related to running on Windows. label Oct 7, 2017
@arsenetar arsenetar self-assigned this Oct 7, 2017
@Quantum00
Copy link
Author

Quantum00 commented Oct 7, 2017

Maybe the error is .pyc instead of .py?
I copy pasted the error message

It is x64, i think i installed it for single user.
You are right at the steps to reproduce it. Scan completes, progress window closes, results window opens and on top of that the error window pops up a whole lot of times (probably as many as the matches? I had 1500 results). I didn't count how many because they wouldn't stop so I ended dupeguru from task manager.
Trying now with a reinstall of the x64 for all users.

@arsenetar
Copy link
Owner

I managed to reproduce the issue when running with debugging, looking into a fix.

@Quantum00
Copy link
Author

Many thanks!

After a reinstall of x64 but all users this time the bug did not occur, but do fix it for single user if you can.

@arsenetar
Copy link
Owner

arsenetar commented Oct 7, 2017

That is interesting that you had a difference there, from what I found it seems there was an issue with calling close on the progress_window dialog multiple times. The issue does not seem to come up every time when I was testing.
@hsoft I have not figured out why close() gets called multiple times but I did create hsoft/qtlib#2 in which close() can now be called multiple times per show() without throwing an exception (later calls do nothing).

@arsenetar arsenetar added the bug Bug reports. label Oct 7, 2017
@Quantum00
Copy link
Author

If it does not come up everytime regardless if it was installed for all or just the current user then that is probably not related. You know better of course.

@ghost ghost added this to the 4.0.4 milestone Oct 8, 2017
This was referenced Nov 14, 2017
ghost pushed a commit that referenced this issue Nov 16, 2017
Update qtlib to prevent error on multiple calls to close the progress window.  I have not been able to duplicate the issue again, to track down the root cause.
Ref #449
@ghost ghost mentioned this issue Dec 1, 2017
@arsenetar arsenetar mentioned this issue Jan 9, 2018
@arsenetar
Copy link
Owner

This has been fixed with the update of qtlib in #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports. Windows Related to running on Windows.
Projects
None yet
Development

No branches or pull requests

2 participants