Merge pull request #873 from glubsy/fix_857

Fix 857
arsenetar · Apr 21, 2021 · 0840104 · 0840104
2 parents 4a40b34 + 6b4b436
commit 0840104
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/qt/app.py b/qt/app.py
@@ -271,6 +271,9 @@ def shutdown(self):
         self.willSavePrefs.emit()
         self.prefs.save()
         self.model.save()
+        # Workaround for #857, hide() or close().
+        if self.details_dialog is not None:
+            self.details_dialog.close()
         QApplication.quit()
 
     # --- Signals

diff --git a/qt/details_dialog.py b/qt/details_dialog.py
@@ -51,7 +51,7 @@ def update_options(self):
             if not self.titleBarWidget():  # default title bar
                 self.setTitleBarWidget(QWidget())  # disables title bar
                 # Windows (and MacOS?) users cannot move a floating window which
-                # has not native decoration so we force it to dock for now
+                # has no native decoration so we force it to dock for now
                 if not ISLINUX:
                     self.setFloating(False)
         elif self.titleBarWidget() is not None:  # title bar is disabled

diff --git a/qt/pe/details_dialog.py b/qt/pe/details_dialog.py
@@ -19,7 +19,6 @@
 class DetailsDialog(DetailsDialogBase):
     def __init__(self, parent, app):
         self.vController = None
-        self.app = app
         super().__init__(parent, app)
 
     def _setupUi(self):