Add support for midnight at the end of day #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1563 1573 +10
Branches 255 259 +4
=====================================
+ Hits 1563 1573 +10
Continue to review full report at Codecov.
|
jadchaar
requested changes
Nov 1, 2019
|
@jadchaar I force-pushed my branch to maintain the same commit message (I also rebased with master branch in the process) |
jadchaar
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Looks good to me!
@systemcatch I think this is good to go, but I want to get another set of eyes just to make sure.
systemcatch
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #703