NonEmptyList: Add bindAll and more unit tests #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serras
approved these changes
Mar 24, 2023
| @@ -84,6 +85,11 @@ public class ResultRaise(private val raise: Raise<Throwable>) : Raise<Throwable> | |||
| @JvmName("bindAllResult") | |||
| public fun <A> Iterable<Result<A>>.bindAll(): List<A> = | |||
| map { it.bind() } | |||
|
|
|||
| @RaiseDSL | |||
| @JvmName("bindAllResult") | |||
There was a problem hiding this comment.
We may have a problem with this name clashing in the Arrow 2.0 branch, where NonEmptyList is defined as a value class.
There was a problem hiding this comment.
Not sure how it would differ when it being a value class 🤔 From Kotlin AST point-of-view it's a different type, and from JVM binary it has a different name.
| @@ -249,6 +250,10 @@ public interface Raise<in Error> { | |||
| @RaiseDSL | |||
| public fun <A> Iterable<Either<Error, A>>.bindAll(): List<A> = | |||
| map { it.bind() } | |||
|
|
|||
| @RaiseDSL | |||
| public fun <A> NonEmptyList<Either<Error, A>>.bindAll(): NonEmptyList<A> = | |||
There was a problem hiding this comment.
If we are including NonEmptyList, should we also include Set and other types of collections?
There was a problem hiding this comment.
Yes, I thought about adding NonEmptySet too today
Kover Report
|
nomisRev
reviewed
Mar 25, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/RaiseAccumulate.kt
Show resolved
Hide resolved
nomisRev
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
bindAllfunction toNonEmptyListfor bothRaiseandRaiseAccumulateimplementations. Additionally, it adds missing unit tests for the NonEmptyList API.