zipOrAccumulate for Raise
#2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
i-walker
approved these changes
Feb 6, 2023
nomisRev
requested changes
Feb 6, 2023
| */ | ||
| @RaiseDSL | ||
| public fun <A, B, C> zipOrAccumulate( | ||
| semigroup: Semigroup<@UnsafeVariance R>, |
There was a problem hiding this comment.
Pending on discussion to remove Semigroup, not blocking for this PR.
Only blocking for 1.2.x release, if we move forward with it's deprecation than we should avoid it in this new signature.
Comment on lines
+394
to
+397
| when (val e = error) { | ||
| is EmptyValue -> return results | ||
| else -> raise(EmptyValue.unbox(e)) | ||
| } |
There was a problem hiding this comment.
Nit: prefer expressions whenever possible.
Suggested change
| when (val e = error) { | |
| is EmptyValue -> return results | |
| else -> raise(EmptyValue.unbox(e)) | |
| } | |
| return when (val e = error) { | |
| is EmptyValue -> results | |
| else -> raise(EmptyValue.unbox(e)) | |
| } |
Comment on lines
+384
to
+393
| val results = mutableListOf<B>() | ||
| forEach { | ||
| fold<R, B, Unit>({ | ||
| block(it) | ||
| }, { newError -> | ||
| error = semigroup.emptyCombine(error, newError) | ||
| }, { | ||
| results.add(it) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Nit: use buildList
Suggested change
| val results = mutableListOf<B>() | |
| forEach { | |
| fold<R, B, Unit>({ | |
| block(it) | |
| }, { newError -> | |
| error = semigroup.emptyCombine(error, newError) | |
| }, { | |
| results.add(it) | |
| }) | |
| } | |
| val results = buildList { | |
| forEach { | |
| fold<R, B, Unit>({ | |
| block(it) | |
| }, { newError -> | |
| error = semigroup.emptyCombine(error, newError) | |
| }, { | |
| add(it) | |
| }) | |
| } | |
| } |
| * using the given [semigroup]. | ||
| */ | ||
| @RaiseDSL | ||
| public fun <A, B, C, D, E> zipOrAccumulate( |
There was a problem hiding this comment.
These need to be inline to allow suspend to pass through the lambdas.
Comment on lines
+377
to
+380
| public fun <A, B> Iterable<A>.mapOrAccumulate( | ||
| semigroup: Semigroup<@UnsafeVariance R>, | ||
| @BuilderInference block: Raise<R>.(A) -> B | ||
| ): List<B> { |
There was a problem hiding this comment.
This needs to be inline to allow suspend to pass through. Cries in context receivers 😭
public inline fun <A, B> Raise<R>.mapOrAccumulate(
semigroup: Semigroup<@UnsafeVariance R>,
list: Iterable<A>,
@BuilderInference block: Raise<R>.(A) -> B
): List<B> {
serras
added a commit
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2880, targeting
maininstead ofarrow-2.This PR adds both
zipOrAccumulateandmapOrAccumulatetoRaise, since the latter was not available in the 1.x branch.