Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Saga type to Arrow Fx Resilience #2902

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Add Saga type to Arrow Fx Resilience #2902

merged 6 commits into from
Feb 2, 2023

Conversation

nomisRev
Copy link
Member

Deprecates https://github.com/nomisRev/Saga, and moves it to the new Arrow Fx Resilience library.

@nomisRev nomisRev added the 1.2.0 Tickets belonging to 1.1.2 label Jan 24, 2023
@nomisRev nomisRev requested review from serras, raulraja, franciscodr and a team January 24, 2023 15:21
raulraja
raulraja approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see Saga being part of Arrow Fx Resilience, thanks @nomisRev !

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Kover Report

File Coverage [68.70%]
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Bracket.kt 50.00%
arrow-libs/fx/arrow-fx-resilience/src/commonMain/kotlin/arrow/fx/resilience/Saga.kt 90.57%
Total Project Coverage 42.48%

@nomisRev nomisRev requested a review from a team January 26, 2023 13:03
franciscodr
franciscodr approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev! 🙌

@serras serras merged commit 33828a4 into main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras serras approved these changes

@raulraja raulraja raulraja approved these changes

@franciscodr franciscodr franciscodr approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
1.2.0 Tickets belonging to 1.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nomisRev @serras @raulraja @franciscodr @i-walker