Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API docs (Dokka) seem to overwrite each other #2882

Closed
CLOVIS-AI opened this issue Jan 1, 2023 · 10 comments
Closed

The API docs (Dokka) seem to overwrite each other #2882

CLOVIS-AI opened this issue Jan 1, 2023 · 10 comments
Assignees

Comments

@CLOVIS-AI
Copy link
Contributor

What version are you currently using?

This is about the hosted API docs in the Arrow website.

Current (buggy) situation

What would you like to see?

The website to be configured correctly such that:

  • there is a single frontpage with all Arrow modules
  • I can configure Dokka in my own projects to link to all Arrow API docs

For reference, here is the Gradle configuration for Dokka 1.7.20 to add links to the KotlinX.Coroutines dokka pages:

tasks.withType<org.jetbrains.dokka.gradle.DokkaTaskPartial>().configureEach {
	dokkaSourceSets.configureEach {
		externalDocumentationLink {
			url.set(URL("https://kotlinlang.org/api/kotlinx.coroutines/"))
		}
	}
}

From this configuration, Dokka is able to find the https://kotlinlang.org/api/kotlinx.coroutines/package-list file which it uses to generate the links (that's the extent of my Dokka knowledge, sorry if I can't help more).

I know that the default Dokka configuration generates the file correctly (I did set up multiple of my projects to reference each other), so it should work more or less out of the box for Arrow as well (though I don't know what post processing is done in your case).

@franciscodr
Copy link
Collaborator

Hi @CLOVIS-AI, first of all, thanks for reporting this bug about the API documentation.

We have solved the issue that prevented you from accessing all the Arrow modules from the navigation menu.

Additionally, the package-list file is already accessible from this URL: https://arrow-kt.io/docs/apidocs/package-list

Please let us know if the error persists or if there are more unexpected behavior in the API documentation. Thanks!

@CLOVIS-AI
Copy link
Contributor Author

Thanks, I will try this.

@CLOVIS-AI
Copy link
Contributor Author

Hi, it seems this is may not be the correct path? I get:

Failed to download package-list from https://arrow-kt.io/docs/package-list, this might suggest that remote resource is not available, module is empty or dokka output got corrupted

To reproduce, create a Dokka project with the following configuration:

tasks.withType<org.jetbrains.dokka.gradle.DokkaTaskPartial>().configureEach {
	dokkaSourceSets.configureEach {
		externalDocumentationLink {
			url.set(URL("https://kotlinlang.org/api/kotlinx.coroutines/"))
		}
		externalDocumentationLink {
			url.set(URL("https://arrow-kt.io/docs/apidocs"))
		}
	}
}

The first link will resolve successfully to KotlinX.Coroutines, but the second prints the error.

@CLOVIS-AI
Copy link
Contributor Author

Nevermind, the trailing slash seems to be necessary. The URL https://arrow-kt.io/docs/apidocs/ works. Thanks a lot for fixing this :)

@CLOVIS-AI
Copy link
Contributor Author

CLOVIS-AI commented Apr 19, 2023

Looks like it's gone again :/

https://gitlab.com/opensavvy/decouple/-/jobs/4143887014#L671

@CLOVIS-AI CLOVIS-AI reopened this Apr 19, 2023
@CLOVIS-AI
Copy link
Contributor Author

@nomisRev told me it has been moved to https://apidocs.arrow-kt.io/package-list. I'll try to change it on my side and will report back.

@CLOVIS-AI
Copy link
Contributor Author

For anyone reading this in the future: Dokka is quite sensitive with how the URL is formatted:

  • https://apidocs.arrow-kt.io: works
  • https://apidocs.arrow-kt.io/: doesn't complain, but doesn't create links either
  • https://apidocs.arrow-kt.io/package-list: doesn't complain, creates links, but they all 404
  • Dokka will complain about other links

@nomisRev
Copy link
Member

@CLOVIS-AI is that something we should report to Dokka?

@CLOVIS-AI
Copy link
Contributor Author

I don't know. Their documentation is not very clear, and I have yet to see another project that actually sets this up…

CLOVIS-AI added a commit to CLOVIS-AI/Pedestal that referenced this issue May 17, 2023
CLOVIS-AI pushed a commit to CLOVIS-AI/Pedestal that referenced this issue May 17, 2023
See arrow-kt/arrow#2882

Closes #63

See merge request opensavvy/pedestal!71
@serras
Copy link
Member

serras commented Jul 3, 2023

This has been solved in the new website, and API Docs show all modules.

@serras serras closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants