Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add possibility to remove VEvent from calendar by id #81

Merged
merged 3 commits into from
Nov 24, 2023
Merged

add possibility to remove VEvent from calendar by id #81

merged 3 commits into from
Nov 24, 2023

Conversation

zachmann
Copy link
Contributor

This adds a simple method to remove an event from a calendar. This addresses #57

@arran4
Copy link
Owner

arran4 commented Nov 23, 2023

LGTM. Running workflow.

@arran4 arran4 self-assigned this Nov 23, 2023
@arran4 arran4 linked an issue Nov 24, 2023 that may be closed by this pull request
Remove event from calendar #57
Closed
@arran4
Copy link
Owner

arran4 commented Nov 24, 2023

Any change of a test before I merge?

arran4
arran4 reviewed Nov 24, 2023
View reviewed changes
@zachmann
Copy link
Contributor Author

Any change of a test before I merge?

I looked for a test for AddEvent which is could use as a base line for a RemoveEvent test, but there are no tests for adding an events, so I left out the test.

@arran4
Copy link
Owner

arran4 commented Nov 24, 2023

All good.

@arran4 arran4 merged commit 7678c37 into arran4:master Nov 24, 2023
@arran4
Copy link
Owner

arran4 commented Nov 24, 2023 

 * [new tag]         v0.2.1 -> v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arran4 arran4 arran4 approved these changes

Assignees

@arran4 arran4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove event from calendar
2 participants
@zachmann @arran4