Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1097 Allow processes to complete #1102

Merged
merged 2 commits into from
Nov 1, 2018
Merged

#1097 Allow processes to complete #1102

merged 2 commits into from
Nov 1, 2018

Conversation

AndyGee
Copy link
Contributor

@AndyGee AndyGee commented Oct 31, 2018

Short description of what this resolves:

Allow processes to complete, and only log errors

Changes proposed in this pull request:

  • org.arquillian.cube.docker.impl.client.CubeSuiteLifecycleController#waitForCompletion should not throw exceptions, as this breaks the lifecycle of other containers

Fixes #1097

@lordofthejars lordofthejars merged commit 95a3588 into arquillian:master Nov 1, 2018
@AndyGee AndyGee deleted the 1097 branch November 2, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordofthejars lordofthejars lordofthejars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to cleanup generated docker networks
2 participants
@AndyGee @lordofthejars