feat: enables HTTPContext to indicate if HTTPS should be used #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
force-pushed
the
context-protocol
branch
from
7ecd26d to
dab9758
Compare
There was a problem hiding this comment.
Thanks for this improvement @jamezp. I have two suggestions to consider.
...r/spi/src/main/java/org/jboss/arquillian/container/spi/client/protocol/metadata/Servlet.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/org/jboss/arquillian/container/spi/client/protocol/metadata/HTTPContext.java
Show resolved
Hide resolved
bartoszmajsak
changed the title
jamezp
force-pushed
the
context-protocol
branch
from
dab9758 to
7fd881d
Compare
…ps should be used. Signed-off-by: James R. Perkins <jperkins@redhat.com>
jamezp
force-pushed
the
context-protocol
branch
from
7fd881d to
fdd05ae
Compare
bartoszmajsak
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ps should be used.
Short description of what this resolves:
Adds the ability to allow for https URL and URI injection.
Changes proposed in this pull request:
isSecure()method to theHTTPContextServletto use the correct protocolFixes #422