Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARQ-2048: Excluded elements in beans.xml by the Weld Arquillian plugi… #35

Merged
merged 1 commit into from
Oct 13, 2016
Merged

ARQ-2048: Excluded elements in beans.xml by the Weld Arquillian plugi… #35

merged 1 commit into from
Oct 13, 2016

Conversation

astefanutti
Copy link
Contributor

…n is an all check instead of an any

@tremes
Copy link
Contributor

tremes commented Oct 13, 2016

I think we should definitely add some test for excluding some bean/s because I think we don't have any. Not really sure why I didn't include one when I was fixing the original issue.

I'll try to add some test.

@tremes tremes merged commit e1bd586 into arquillian:master Oct 13, 2016
@astefanutti astefanutti deleted the ARQ-2048 branch October 13, 2016 12:57
@astefanutti
Copy link
Contributor Author

@tremes Thanks for the merge. I agree with you that some tests would be worth the effort. I'll try to find some time ASAP.

@tremes
Copy link
Contributor

tremes commented Oct 13, 2016

@astefanutti you're more than welcome.:-) I already introduced some basic one. Feel free to expand it.

@astefanutti
Copy link
Contributor Author

Ah I've just seen you pushed @cba0c735adff9c9b0defb9d5e05d426c2573baf2. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants