Adapt container to recognize and honor annotated discovery mode. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I have updated the PR so that it now considers EJB annotations as bean defining if the discovery mode is |
|
I am fairly confident these changes will do. I have run Weld TS using this container with changes contained here and it worked for me. @starksm64 if you could also perform a release with this change, that would be great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
The crux of this change is that CDI 4.0 will change the default perception of empty beans.xml from
alltoannotated. This changes what beans should and shouldn't be discovered by default. Up until this point, arq-conteiner-weld was simply usingallat all times.I am currently testing this with Weld to see if further changes are needed, hence it is now a draft.