Fix librdkafka 1.6 tests (#437)

arnaud-lb · Jan 14, 2021 · ec302d2 · ec302d2
1 parent 3ee8765
commit ec302d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -15,6 +15,12 @@ jobs:
               - php: '7.4.0'
                 librdkafka: 'v1.5.0'
                 memcheck: '1'
+              - php: '8.0.0'
+                librdkafka: 'v1.6.0-RC1'
+              - php: '7.4.0'
+                librdkafka: 'v1.6.0-RC1'
+              - php: '7.3.0'
+                librdkafka: 'v1.6.0-RC1'
               - php: '8.0.0'
                 librdkafka: 'v1.5.0'
               - php: '7.4.0'

diff --git a/rdkafka.c b/rdkafka.c
@@ -146,7 +146,9 @@ static void kafka_init(zval *this_ptr, rd_kafka_type_t type, zval *zconf) /* {{{
 
     intern->cbs.zrk = *this_ptr;
     rd_kafka_conf_set_opaque(conf, &intern->cbs);
-    rd_kafka_conf_set_dr_msg_cb(conf, kafka_conf_dr_msg_cb);
+    if (type == RD_KAFKA_PRODUCER) {
+        rd_kafka_conf_set_dr_msg_cb(conf, kafka_conf_dr_msg_cb);
+    }
 
     rk = rd_kafka_new(type, conf, errstr, sizeof(errstr));