-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECDSA implementation #2
Comments
@stevencedro did this get merged? I can't find the implementation anywhere :( |
@trancee I haven't had a chance to implement this yet. I was waiting for someone to start requesting these features due to time constraints. I'll start working on it today and comment back here when it's done. Thanks! |
@trancee ECDSA implementation completed. I added quite a considerable amount of tests however as with any pre-release libraries, some bugs/implementation errors might slip through. If you come across anything, please raise an issue and I'll look into it. What I'm mainly concerned with is the cross-compatibility between this library and the actual WebCrypto browser/node implementations which are the main motivations for this library (e.g. sending keys/signatures from browser client to a server written in Go ). If you're using this library to communicate with a frontend application that uses the WebCrypto API and come across any incompatibilities, do let me know also until #31 is completed. Finally, the next ticket I'll be working on is a slight refactor in the way algorithm params are passed into the subtle functions. Monitor #29 for upcoming changes. For now, follow the example here for the current implementation, and I'll update it once #29 is completed. Thanks and happy coding! |
@stevencedro Wow, that was quite fast work! Thank you very much for the implementation, I will try to use it within my project, and let you know if I hit any issues on the way. One thing I have noticed is that you only use |
@trancee I added an issue #32 for the exportKey raw support. I'll get onto that after I finish #29. Do note though that it seems the WebCrypto spec states that exported ECDSA keys in raw format will only export Thanks! |
Implementation of ECDSA operations as per W3C specification at https://www.w3.org/TR/WebCryptoAPI/#ecdsa
The text was updated successfully, but these errors were encountered: