Skip to content

Commit

Permalink
net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()
Browse files Browse the repository at this point in the history
When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0.
So, we use -ENOMEM to indicate that the function
create_singlethread_workqueue() return NULL.

Clean up smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
mlx5e_arfs_create_tables() warn: missing error code 'err'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: f6755b8 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Yang Li authored and Saeed Mahameed committed Jun 10, 2021
1 parent 13c62f5 commit 2bf8d2a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ static int arfs_create_table(struct mlx5e_priv *priv,

int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
{
int err = 0;
int err = -ENOMEM;
int i;

if (!(priv->netdev->hw_features & NETIF_F_NTUPLE))
Expand Down

0 comments on commit 2bf8d2a

Please sign in to comment.