Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplex change in 3.5.1 broke "duplex = off" #33

Closed
just6979 opened this issue Nov 4, 2024 · 15 comments
Closed

Duplex change in 3.5.1 broke "duplex = off" #33

just6979 opened this issue Nov 4, 2024 · 15 comments

Comments

@just6979
Copy link

just6979 commented Nov 4, 2024

"Duplex = off" does nothing since 3.5.1. See #27 (comment)

It seems that "Duplex = off" is not being changed into "Duplex = -" as it used to be.

I can do an upload with "Duplex = off" in Chirp, however those channels will TX until I use the radio menus to change the offset to "-". Then the "fake tx disable" of forcing TX on 0.000 MHz works as expected, because the offset is still equal to the freq (in the radio, Chirp still shows the offset as empty), it's just that the "Duplex = off" after uploading with >= 3.5.1.

On a slightly seperate note:
When Duplex is "-", and the offset freq = channel freq (in the radio, Chirp still shows it empty), and TX Lock = ON, the the radio actually shows TX DISABLED as expected, instead of the weirdness of literally trying to TX on 0.000 MHz. I guess this makes sense, since the TX freq of 0.000 MHz is outside of any F Plan except Unlock All, thus allowing TX Lock to act as a denylist.

However, what would really be nice is if TX Lock simply acted as both an allowlist for freqs outside the F Plan as it does now, and also a denylist for freqs inside the F Plan (without needing the offset=freq weirdness). This way we could keep the real offsets stored for channels in the F Plan, but prevent TXing on them without first going into the menu and turning TX Lock to OFF. This can be useful if you want a duplex channel to act as RX-only, but also want to be able to sometimes listen in Reverse mode as well.

@armel
Copy link
Owner

armel commented Nov 4, 2024

The real question is: why save a memory channel that is in my FLock band plan, but on which I don't want to transmit? Use case ?
By the way, maybe your band plan isn't suited to your use? Also, if you're not a radio amateur, it's probably more efficient to use DISABLE ALL and take care of the TX Lock?
My 2 cents.

@just6979
Copy link
Author

just6979 commented Nov 4, 2024

I usually just use the Default F-Lock because it contains the US Amateur, MURS, and GMRS freqs, but also many Public Safety freqs that I used to easily disable TX with Duplex = Off.

Perhaps I will switch to FCC Ham F-Lock and use TX Lock = Off to enable the GMRS and MURS channels I want.

So yes, that is a valid way to acheive what I want, but it doesn't fix that "Duplex = Off" is broken and does not act as expected for a regular Chirp user. Perhaps that option should be removed from the driver if it's not fixed to fit with Chirp expectations: "If the duplex is set to off then transmission on this channel will be disabled (if the radio supports this capability)."

@armel
Copy link
Owner

armel commented Nov 4, 2024

I usually just use the Default F-Lock because it contains the US Amateur, MURS, and GMRS freqs, but also many Public Safety freqs that I used to easily disable TX with Duplex = Off.

Sorry but, using DISABLE ALL and using TXLock to open exceptions, is probably the best solution here, not the dirty Duplex OFF hack :)

Perhaps I will switch to FCC Ham F-Lock and use TX Lock = Off to enable the GMRS and MURS channels I want.

Very good idea, I can only encourage you to do it. How many GMRS and MURS channels ? Less than 20 ? It's easy and quickly to do.

Perhaps that option should be removed from the driver if it's not fixed to fit with Chirp expectations: "If the duplex is set to off then transmission on this channel will be disabled (if the radio supports this capability)."

The important words here are "if the radio supports this capability" :)

In my opinion, Duplex can be + or - AND with an offset, or OFF for a simplex frequency. That's all and that's how it works today. Then, you can also play with setting an offset outside the band plan, but that's dirty.

I'll let @joc2 give his opinion. But for me, how it works today is nice.

Armel.

@just6979
Copy link
Author

just6979 commented Nov 4, 2024

Yeah, it's only about a 20% of my memory channels that will need an override, so I'll go with FCC Ham FLock and open them with TX Lock Off. Guess this confusion is what I get for adapting my configuration solely based on other less flexible (no FLock plans, no TX Lock options except Duplex Off) radios!

"The important words here are "if the radio supports this capability" :)"

Ah, but the radio/firmware does support this capability, doesn't it? The concept and functionality of "TX Disable" is present in this firmware, it's just only used for F Lock funtionality. I'm pretty sure "Off" won't be an option if the radio doesn't support using it for TX Disable.

"In my opinion, Duplex can be + or - AND with an offset, or OFF for a simplex frequency"

Except Chirp says "Note that for simplex channels, this should be set to (None)". In fact, it looks like setting None in the 3.5.2 driver forces it to Off, which against the Chirp recommendation and unlike other radios I've used with Chirp. Perhaps Off could force it to None for clarity, or maybe better that Off should be removed if it's not actually supported. I guess we'll let @joc2 decide.

Thanks for the quick and thorough responses! Always interesting to see how different folks think about both bypassing and enforcing limits and configurations and such.

@joc2
Copy link
Collaborator

joc2 commented Nov 7, 2024

Hi , i just see that,
where is this : Except Chirp says "Note that for simplex channels, this should be set to (None)".

i dont see where you see it.

@just6979
Copy link
Author

just6979 commented Nov 7, 2024

https://chirpmyradio.com/projects/chirp/wiki/MemoryEditorColumns#Duplex

Specifically says that simplex channels should be set to None and RX-only should use "Off". Using "Off" for simplex is unusual and doesn't match Chirp's own recommendations.

With TX Lock support, the "Off" duplex mode should be removed. This is actually better than the hack of "Off" for RX-only, since it keeps the offsets in radio memory so Reverse/Talkaround can be used. for listening on the offset freq. But "Off" for simplex along with the forcing None to "Off" is confusing.

@armel
Copy link
Owner

armel commented Nov 7, 2024

@just6979 Ok Justin, sounds good to me. So the best solution is probably to delete “Off” and leave only “None”, “+” and “-”.
@joc2 your advise ? You're the key master of this Chirp driver 😉

@joc2
Copy link
Collaborator

joc2 commented Nov 7, 2024

Hi, this is the first time i saw that page , i dont know that chirp describe functionality of those setting, Chirp is the base software we uses for many radio and the ( driver i program ) is adapt to the radio specification... not the reverse normaly.... but your right in this case,

But more confusing. chirp do not allow None has a option of selection, ( this is built in chirp main program)
even if they say in that documentation web page that None can be set...
here is the test i did to see what chirp list is allow. and it pop me this error.

debug log of chirp...
[2024-11-07 03:14:52,396] chirp.wxui.memedit - ERROR: Failed to load memory 138 as error because: `None' is not in valid list: ['', '+', '-', 'split', 'off']

So, i can't put None in the list, the only thing i can put is empty and remove the display of the off. Empty mean NONE.

image

what do you think in that case

@armel
Copy link
Owner

armel commented Nov 7, 2024

@joc2 Ok for me. Delete “Off” and leave only “+”, “-” and "".

@just6979
Copy link
Author

just6979 commented Nov 7, 2024

Sorry, I guess I didn't ever specify that I mean the empty string "" for None. I used "" sometimes, but then saw that Chirp docs usually uses None when the actual value is "". 👍

@joc2
Copy link
Collaborator

joc2 commented Nov 8, 2024

ok, it will be done in the next release 3.6.2... maybe this weekend

joc2 added a commit that referenced this issue Nov 10, 2024
@joc2
Copy link
Collaborator

joc2 commented Nov 10, 2024

it's update on version 3.6.3

@joc2 joc2 closed this as completed Nov 10, 2024
@baffles
Copy link

baffles commented Nov 29, 2024

I feel like I'm missing something here. Is there a way to set tx lock for certain presets in chirp for rx-only? Do I really have to go through them one by one on the radio and save them back?

@just6979
Copy link
Author

You need to turn on "Show extra fields" in Chirp's View menu. Or pull up the properties for a channel or selection of channels and go to the Extra tab.

@baffles
Copy link

baffles commented Dec 5, 2024

Ah perfect. Thank you @just6979!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants