Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip/64: fix again periodic dma and audio stuttering #7853

Merged
merged 3 commits into from
Feb 23, 2025

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Feb 20, 2025

Description

In reference to #7695 and then #7813, this PR should finally fix the problems with DMA and click and pops during audio playing.

Re-enables the pl330 patches for rockchip and rockchip64 families, for both current 6.12 and edge 6.13 kernels.

Absolutely no rush to let this make in 25.02 release: it is better to let it bake properly

GitHub issue reference:
Jira reference number AR-2584

How Has This Been Tested?

  • Tested on Orange PI 4 LTS on a brand new installation with Ubuntu Noble + xfce + pulseaudio on I²S analog codec
  • Tested on a rk322x tv box on a Debian Bookworm minimal installation + pulseaudio on I²S analog codec
  • Tested on a rk3328 tv box on Ubuntu Noble + xfce + pulseaudio on I²S analog codec
  • Tested on rk3308 Rockpi-s on Debian Bookwom minimal installation on I²S analog codec and SPDIF output

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@paolosabatino paolosabatino requested a review from a team February 20, 2025 11:42
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Feb 20, 2025
@paolosabatino paolosabatino added the Ready to merge Reviewed, tested and ready for merge label Feb 23, 2025
@igorpecovnik igorpecovnik merged commit 86691d1 into armbian:main Feb 23, 2025
10 checks passed
@paolosabatino paolosabatino deleted the fix-periodic-dma-again branch February 23, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants