Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKS-Klipad50: Switch to standard support #7851

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

torte71
Copy link
Contributor

@torte71 torte71 commented Feb 20, 2025

Switch MKS-Klipad50 to standard support.

Do I need to update https://www.armbian.com/update-data/ again?
I have added my data already about 3 weeks ago on the initial import.

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Feb 20, 2025
@igorpecovnik
Copy link
Member

Do I need to update

No, just once. If relation to this board is already there, then this is it.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release 05 Milestone: Second quarter release labels Feb 20, 2025
@igorpecovnik
Copy link
Member

BTW: website status is still at manual change.

@igorpecovnik igorpecovnik merged commit 4bddce9 into armbian:main Feb 21, 2025
13 checks passed
@torte71
Copy link
Contributor Author

torte71 commented Feb 21, 2025

BTW: website status is still at manual change.

Sorry, but I don't get what you mean.
Do I have to change anything? (I saw the support selection box in the device wordpress template can be set to standard support)
Or does it just mean that until the release the Armbian pages won't be updated?

@igorpecovnik
Copy link
Member

Do I have to change anything? (I saw the support selection box in the device wordpress template can be set to standard support)

This, yes, optionally. If (most of) conditions applies: https://docs.armbian.com/User-Guide_Board-Support-Rules/#standard-support

Or does it just mean that until the release the Armbian pages won't be updated?

It can be done now. Website is not fully automatized ... we will probably ditch it and make it from scratch one day.

@torte71
Copy link
Contributor Author

torte71 commented Feb 22, 2025

I still don't understand, what you are referring to (and if or what actions I or you need to take).

I changed the support type in the wordpress template to "standard" and now it gets listed below standard support on https://www.armbian.com/download - just as expected.
The image files on https://www.armbian.com/mks-klipad50/ still refer to the community builds, but I thought that is because the images at https://github.com/armbian/os/ have not been rebuilt yet (since klipad was changed from .csc to .conf).

Your comments look to me, as if there are still additional steps required for a "manual change" of the "website status", but I have no idea, what these steps could be and what they will change.

@torte71
Copy link
Contributor Author

torte71 commented Feb 23, 2025

Did you refer to the "Build Standard Support Images" workflow being triggered manually?
Then yes, it would be nice if this would be run for the mksklipad50.

(I somehow overlooked that this workflow is not triggered automatically and focused only on finding another kind of automatism where "status is at manual change" could apply.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release 05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants