-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump two leftover radxa rk35xx uboot to next-dev-v2024.10 #7832
Conversation
I think the uboot config in board config can just get dropped, just like other rk3588 boards, default uboot source is defined in family. |
I thought so at first, but wasn't sure. |
03e9ad6
to
a6cac1c
Compare
For mixtile edge2 there should be additional changes:
For all rk356x boards they should use rk35xx as BOARDFAMILY, and when building mainline kernels, the LINUXFAMILY will be set to rockchip64. |
just remove these leftover overrides. Signed-off-by: nyanmisaka <nst799610810@gmail.com> Co-authored-by: amazingfate <liujianfeng1994@gmail.com>
a6cac1c
to
86be9df
Compare
Thx for your explanation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Rock 5c:
Vendor Noble Gnome (full test)
Vendor Minimal Bookworm (full test)
Current Minimal Bookworm (boot)
Description
There are two boards that were missed when upgrading to next-dev-v2024.10. Bump version for them too.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh build ARTIFACT_IGNORE_CACHE=yes BOARD=rock-5c BRANCH=vendor BUILD_DESKTOP=no BUILD_MINIMAL=no KERNEL_CONFIGURE=yes RELEASE=noble
Checklist:
Please delete options that are not relevant.