Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rock 2A and 2F #7820

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Add support for Rock 2A and 2F #7820

merged 2 commits into from
Feb 20, 2025

Conversation

CodeChenL
Copy link
Contributor

Description

  1. Add support for Rock 2A and 2F
  2. use systemd.link instead of udev rule(99-radxa-aic8800.rules)

How Has This Been Tested?

  • ./compile.sh build BOARD=rock-2a BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=noble DOWNLOAD_MIRROR=china
  • ./compile.sh build BOARD=rock-2f BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=noble DOWNLOAD_MIRROR=china

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Feb 11, 2025
@CodeChenL
Copy link
Contributor Author

@RadxaStephen @lsj123lsjlsj @RadxaYuntian Please review together

Copy link
Collaborator

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to make AIC88800 link renaming a shared function.

@CodeChenL
Copy link
Contributor Author

CodeChenL commented Feb 12, 2025

Hi @amazingfate , i see arm64: dts: rk3528: use lima driver for gpu was submitted by you, could you please tell me if you tested glmark-es2 under gnome X11?
I run it on rock2f with only 80-90 points, under wayland with 280-300 points
Can achieve 280-300 points when running glmark-es2 using xfce with radxa os bullseye
I'm not sure if the weak performance under x11 is a common thing with armbian or just rock2.

@github-actions github-actions bot added the Framework Framework components label Feb 12, 2025
@amazingfate
Copy link
Contributor

Hi @amazingfate , i see arm64: dts: rk3528: use lima driver for gpu was submitted by you, could you please tell me if you tested glmark-es2 under gnome X11? I run it on rock2f with only 80-90 points, under wayland with 280-300 points Can achieve 280-300 points when running glmark-es2 using xfce with radxa os bullseye I'm not sure if the weak performance under x11 is a common thing with armbian or just rock2.

I have tested with hinlink ht2, ubuntu noble gnome x11 session the glmark-es2 score is also 80~90. While glmark2-es2-wayland is better. And score of glmark-es2 under wayland session can reach to 120.

@CodeChenL
Copy link
Contributor Author

Hi @amazingfate , i see arm64: dts: rk3528: use lima driver for gpu was submitted by you, could you please tell me if you tested glmark-es2 under gnome X11? I run it on rock2f with only 80-90 points, under wayland with 280-300 points Can achieve 280-300 points when running glmark-es2 using xfce with radxa os bullseye I'm not sure if the weak performance under x11 is a common thing with armbian or just rock2.

I have tested with hinlink ht2, ubuntu noble gnome x11 session the glmark-es2 score is also 80~90. While glmark2-es2-wayland is better. And score of glmark-es2 under wayland session can reach to 120.

Thanks for the test, that doesn't look like I did anything wrong or missed any changes.

@igorpecovnik
Copy link
Member

Here you need to tell me when its ready, no way to check.

And move naming_wireless_interface to radxa-aic8800.sh

To avoid unexpected errors caused by ID_NET_SLOT being empty when using lower version udev
@CodeChenL
Copy link
Contributor Author

CodeChenL commented Feb 18, 2025

Hi @igorpecovnik, I've squashed the previous commit. Now this PR is ready for another review.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Feb 19, 2025
@igorpecovnik igorpecovnik merged commit 135bbc4 into armbian:main Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

4 participants