Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cpu internal ethernet on nanopi-r4se standard version without EEPROM #7739

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jpy794
Copy link
Contributor

@jpy794 jpy794 commented Jan 23, 2025

Description

Like nanopi-r4s, nanopi-r4se has two variants1: enterprise and standard version. The difference between the two variants is that the enterprise version has an extra EEPROM to store globally unique MAC address for rk3399's internal ethernet. Currently Armbian r4se device tree is based on r4s-enterprise device tree, which breaks cpu internal ethernet on the standard version due to lack of valid MAC address from EEPROM.

Kernel logs

platform fe300000.ethernet: deferred probe pending: platform: wait for supplier /i2c@ff120000/eeprom@51/mac-address@fa

Since Armbian only maintains image for nanopi-r4s standard version (runs on enterprise board too, just ignoring the unique MAC address), I think it's reasonable to do the same for r4se.

How Has This Been Tested?

Tested on my nanopi-r4se standard version, by installing the dtb package built with ./compile.sh kernel-dtb BOARD=nanopi-r4se BRANCH=edge

Footnotes

  1. Although not well documented like r4s, you could see the empty EEPROM paste at the front of r4se board in their wiki.

@jpy794 jpy794 requested a review from igorpecovnik as a code owner January 23, 2025 09:33
@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines labels Jan 23, 2025
@igorpecovnik
Copy link
Member

Thank you! I would propose the same fix for K6.12, which is going to be around for awhile.

@jpy794
Copy link
Contributor Author

jpy794 commented Jan 23, 2025

Thank you! I would propose the same fix for K6.12, which is going to be around for awhile.

Sure, applied to K6.12 too now.

@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 23, 2025
@igorpecovnik igorpecovnik merged commit 9e45573 into armbian:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants