Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K3: Use sfdisk instead of parted for setting flag in boot partition #7677

Merged
merged 1 commit into from
Jan 8, 2025
Merged

K3: Use sfdisk instead of parted for setting flag in boot partition #7677

merged 1 commit into from
Jan 8, 2025

Conversation

3V3RYONE
Copy link
Contributor

@3V3RYONE 3V3RYONE commented Jan 8, 2025

The latest 'parted' package that is shipped with Ubuntu noble does not allow to set the 'lba' flag on MBR/DOS partitions and fails with an error. Use 'sfdisk' instead for the same.

Fixes #6956

GitHub issue
Jira issue

How Has This Been Tested?

  • Build and Boot tested on SK-AM62B board.
  • Build and Boot tested on SK-TDA4VM board.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@glneo @3V3RYONE
K3: Use sfdisk instead of parted for setting flag in boot partition
be63e59 
The latest 'parted' package that is shipped with Ubuntu noble does not
allow to set the 'lba' flag on MBR/DOS partitions and fails with an
error. Use 'sfdisk' instead for the same.

Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
@3V3RYONE 3V3RYONE requested a review from igorpecovnik as a code owner January 8, 2025 08:03
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jan 8, 2025
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 8, 2025
@igorpecovnik igorpecovnik merged commit ef0a4a3 into armbian:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Bugfix Pull request is fixing a bug Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parted compatibility issue related to Ubuntu Noble
3 participants
@3V3RYONE @igorpecovnik @glneo