Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uwe5622 "spanning-writes" warning messages in dmesg #7615

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Dec 26, 2024

Description

Spreadtrum/Unisoc wifi uwe5622 driver is producing a lot of warning messages with consequent kernel dumps in dmesg when run with a recent kernel. The driver is functional, but the kernel complaints.

This PR will fix the problem with kernel >= 6.12 using DECLARE_FLEX_ARRAY() macro in place of u8 data[0] flexible array declarations that are causing the warnings. Note that this probably could be applied to older kernels as well, since the DECLARE_FLEX_ARRAY() macro is available from 5.15 onwards.

This applies to both rockchip64 (OrangePi 4 LTS uses this part), but also to some sunxi boards.

GitHub issue reference:
Jira reference number AR-2574

How Has This Been Tested?

  • Compiled rockchip64 edge 6.13-rc4 kernel debs and tested on a live installation
  • Compiled rockchip64 current 6.12 kernel debs and tested on a live installation
  • iperf3 benchmarks, performance is ok
  • ssh tests, connectivity is ok

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@paolosabatino paolosabatino requested review from a team December 26, 2024 15:26
@paolosabatino paolosabatino requested review from a team and igorpecovnik as code owners December 26, 2024 15:26
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components Patches Patches related to kernel, U-Boot, ... labels Dec 26, 2024
@paolosabatino paolosabatino merged commit 06c37e5 into armbian:main Dec 26, 2024
@paolosabatino paolosabatino deleted the rockchip64-fix-uwe5622 branch December 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants