Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ROCKCHIP_THUNDER_BOOT_DEFER_FREE_MEMBLOCK #7580

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

nyanmisaka
Copy link
Collaborator

Description

"Very low threads-max value on this kernel" armbian/linux-rockchip#307

ROCKCHIP_THUNDER_BOOT_DEFER_FREE_MEMBLOCK should depend on ROCKCHIP_THUNDER_BOOT,
and it creates an artificial threads-max limit that is not suitable for generic linux.

According to a discussion from a few months ago, disabling the config intruduced in rkr3 fixed the problem.

The config was accidentally enabled in #7300

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

`ROCKCHIP_THUNDER_BOOT_DEFER_FREE_MEMBLOCK` should depend
on `ROCKCHIP_THUNDER_BOOT`, and it creates an artificial
threads-max limit that is not suitable for generic linux.

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Dec 15, 2024
@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 15, 2024
@amazingfate amazingfate merged commit 13e10e1 into main Dec 15, 2024
@amazingfate amazingfate deleted the nyanmisaka-patch-1 branch December 15, 2024 10:50
@sdeleeuw
Copy link
Collaborator

This commit/PR fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants