Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip: various fixes (usb, alsa, ...) for rk3288/rk322x #7539

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Dec 4, 2024

Description

Various important and less important fixes that emerged after kernel bump to 6.12 for rockchip 32 bit target, mostly due to mainline patches that broke compatibility. 🙄

  • Asus Tinkerboard was having issues with USB (again): a patch in mainline kernel broke the snps,reset-on-wake quirk, which in turn broke USB functionality when plugging USB devices after boot. This also affected the CSC board xt-q8l-v10.
  • fixed asound.conf to allow ALSA correctly detect hdmi/iec958 (spdif) devices, so PulseAudio is able to show something else than "analog audio" for HDMI and SPDIF. This mainline patch broke the existing behaviour: adding driver->name to simple-audio-card pseudo-device makes ALSA enumerate in a completely different way the audio cards. audio-graph-card and audio-graph-card2 pseudo-devices did not receive the same treatment, so they still work (also applies to 6.6).
  • remove some leftovers from 6.11 and cleaned up some patches to avoid warnings.

GitHub issue reference:
Jira reference number AR-2548

How Has This Been Tested?

  • Built packages and tested on Asus Tinkerboard S and xt-q8l-v10 (rk3288)
  • Built packages and tested on rk322x-box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

sound node in device trees have been migrated to audio-graph-card2
to overcome limitations and configuration mayhems in ALSA userland
libraries
this commit reverts commit ca2dc35e555e7043de585f4e46123d8fbd2b5a21
from mainline kernel because rk3288 requires clock gating to
assert irq on usb device plug in and thus proceed with
reset-on-wake quirk
@paolosabatino paolosabatino requested a review from a team December 4, 2024 16:13
@paolosabatino paolosabatino requested review from a team and igorpecovnik as code owners December 4, 2024 16:13
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... BSP Board Support Packages labels Dec 4, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release labels Dec 4, 2024
@igorpecovnik igorpecovnik merged commit 3839eaa into armbian:main Dec 4, 2024
@paolosabatino paolosabatino deleted the rockchip-fixes branch December 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release BSP Board Support Packages Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants