Enable CONFIG_VHOST_VSOCK on rockchip64 #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfa
requested review from
Manouchehri,
TRSx80,
TheSnowfield,
Tonymac32,
ahoneybun,
amazingfate,
brentr,
catalinii,
clee,
igorpecovnik,
joekhoobyar,
krachlatte,
paolosabatino and
rpardini
as code owners
github-actions
bot
added
size/small
amazingfate
approved these changes
Nov 24, 2024
igorpecovnik
added
Ready to merge
igorpecovnik
approved these changes
Nov 25, 2024
|
Would love this on RK3588 |
|
Should be the case now since rk3588 has been merged into rockchip64. Build a new image or just kernel package and the module should be available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Incus (LXD fork after Canonical takeover) container and VM management tools require
CONFIG_VHOST_VSOCKto be enabled to use VMs, and some targets are missing that option. I'm not sure of the implications, but they seem to be null as this is linked to the virtio subsystem.Documentation summary for feature / change
How Has This Been Tested?
I did test this on my helios64 with kernel 6.6.47 and I was able to start a VM with Incus.
Checklist:
Please delete options that are not relevant.