Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootfs-to-image: preserve sparse files when moving artefacts to final destination with rsync #7492

Merged
merged 1 commit into from
Dec 24, 2024
Merged

rootfs-to-image: preserve sparse files when moving artefacts to final destination with rsync #7492

merged 1 commit into from
Dec 24, 2024

Conversation

alex3d
Copy link
Contributor

@alex3d alex3d commented Nov 17, 2024

Description

Images built on macos did not preserve sparseness and did occupy full apparent size (when created with FIXED_IMAGE_SIZE).
Fix it by rsync --sparse option

How Has This Been Tested?

  • Build image on MacOS

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@alex3d alex3d requested a review from a team as a code owner November 17, 2024 20:59
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Nov 17, 2024
@igorpecovnik igorpecovnik added the 02 Milestone: First quarter release label Nov 18, 2024
rpardini
rpardini approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never encountered the problem this aims to solve, but I also can't see how this would break anything.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 21, 2024
@igorpecovnik igorpecovnik merged commit 4fd0e0c into armbian:main Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpardini rpardini rpardini approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex3d @rpardini @igorpecovnik