Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MKNOD capability to dockershell container #6927

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

JohnTheCoolingFan
Copy link
Contributor

@JohnTheCoolingFan JohnTheCoolingFan commented Jul 10, 2024

Description

Added arguments --cap-add MKNOD to docker run command to allow losetup -f to create the loop device node.
Fixes #6568

GitHub issue reference: #6568
Jira reference number AR-2132

How Has This Been Tested?

Running ./compile.sh build BOARD=odroidm1 BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=no KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=bookworm (auto defaults to build in docker)

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JohnTheCoolingFan JohnTheCoolingFan requested a review from a team as a code owner July 10, 2024 14:27
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jul 10, 2024
Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rpardini
Copy link
Member

Worth noting: this is adding the cap to the dockershell cli command only

@rpardini
Copy link
Member

How Has This Been Tested?

Running ./compile.sh build BOARD=odroidm1 BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=no KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=bookworm

This doesn't match the code change done. The change affects dockershell only!

@JohnTheCoolingFan
Copy link
Contributor Author

JohnTheCoolingFan commented Jul 10, 2024

@rpardini it auto defaults to docker on my machine, that's why.
This affects the docker script, and in my use case - that command, ran on THE HOST launches the build in docker. I don't know the option to force docker off the top of my head, so that's how I tested it. First ./compile.sh KERNEL_GIT=shallow to reproduce the issue and then copied the full command that was printed to stdout

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jul 11, 2024
@JohnTheCoolingFan JohnTheCoolingFan merged commit 8162899 into armbian:main Jul 11, 2024
11 checks passed
@rpardini
Copy link
Member

I can't follow. The PR only changes dockershell.

@JohnTheCoolingFan
Copy link
Contributor Author

I can't follow. The PR only changes dockershell.

I finally understand what you were talking about.
I assumed that build would call womething from cli-docker.sh to relaunch in docker and build in docker, looks like that's not the case. Will do a follow-up.

It won't hurt to add that capability to dockershell as well, but I apologize for the misunderstanding on my part.

The difficulty of testing is that after a first failed run the /dev/loop0 device stays and in the next docker launch it is available and I can't find the way to remove it without rebooting the system.

@JohnTheCoolingFan JohnTheCoolingFan changed the title Add MKNOD capability to docker container Add MKNOD capability to dockershell container Jul 12, 2024
JohnTheCoolingFan added a commit to JohnTheCoolingFan/armbian-build that referenced this pull request Jul 12, 2024
This reverts commit 8162899.

The capability has nothing top do with the actual issue.
JohnTheCoolingFan added a commit to JohnTheCoolingFan/armbian-build that referenced this pull request Jul 12, 2024
This reverts commit 8162899.

The capability has nothing top do with the actual issue.
JohnTheCoolingFan added a commit to JohnTheCoolingFan/armbian-build that referenced this pull request Aug 14, 2024
This reverts commit 8162899.

The capability has nothing top do with the actual issue.
JohnTheCoolingFan added a commit to JohnTheCoolingFan/armbian-build that referenced this pull request Aug 14, 2024
This reverts commit 8162899.

The capability has nothing top do with the actual issue.
igorpecovnik pushed a commit that referenced this pull request Aug 18, 2024
This reverts commit 8162899.

The capability has nothing top do with the actual issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

Fail at check_loop_device: device node doesn't exist and LOOP= in cycle 1
4 participants