Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default boot blobs for RK3528, RK3566 and RK3568 and use them for NanoPi R5C #6822

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

@ColorfulRhino ColorfulRhino commented Jun 28, 2024

Description

As mentioned here: #6810 (comment)

Out of date blobs can be an issue if the vendor ships boards with new blobs, as recently seen for FriendlyElec with the NanoPC T6 for example.

The release docs do not mention any incompatibilities between versions for rk3528 and rk3568:
https://github.com/armbian/rkbin/blob/master/patch-notes/RK3528_EN.md
https://github.com/armbian/rkbin/blob/master/patch-notes/RK3568_EN.md

For rk3566, only one warning is listed for rk3566_ddr_1056MHz_ultra_v1.19.bin but we're not using the ultra blob (what's the difference?):
https://github.com/armbian/rkbin/blob/master/patch-notes/RK3566_EN.md#rk3566_ddr_1056mhz_ultra_v119bin

ROCK_USB_BLOB bump depends on armbian/rkbin#29 being merged.
Other blobs have already been merged to armbian/rkbin in the past.

How Has This Been Tested?

  • RK3568: ./compile.sh uboot ARTIFACT_IGNORE_CACHE=yes BOARD=nanopi-r5c BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no EXPERT=yes KERNEL_CONFIGURE=no RELEASE=trixie
  • RK3566: Not tested - @RadxaNaoki would be great if you could test on Raxda Zero 3 or similar board 😊
  • RK3528: Not tested - @amazingfate @sputnik2019 would be great if you could test on a RK3528 board 😊 (although the doc does not list any incompatibilities)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Hardware Hardware related like kernel, U-Boot, ... labels Jun 28, 2024
@ColorfulRhino
Copy link
Collaborator Author

NB: ROCK_USB_BLOB bump depends on armbian/rkbin#29 being merged.

Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent. sanity is restored. flexibility is kept. merge

This fixes several issues as described in the changelog doc at
https://github.com/armbian/rkbin/blob/master/patch-notes/RK3568_EN.md

The doc does not mention any incompatibilities between versions.
This fixes several issues as described in the changelog doc at
https://github.com/armbian/rkbin/blob/master/patch-notes/RK3528_EN.md

The doc does not mention any incompatibilities between versions.
Also move the ROCK_USB variable for RK3588 from rk3588.conf to rockchip64.conf to achieve consistency.
Remove the now obsolete variable for OrangePi 3B
@ColorfulRhino
Copy link
Collaborator Author

@rpardini You can also consider removing the blobs on OPi 3B

DDR_BLOB="rk35/rk3566_ddr_1056MHz_v1.18.bin"
BL31_BLOB="rk35/rk3568_bl31_v1.43.elf" # NOT a typo, bl31 is shared across 68 and 66

and Odroid M1

# Newer blobs...
DDR_BLOB="rk35/rk3568_ddr_1560MHz_v1.18.bin"
BL31_BLOB="rk35/rk3568_bl31_v1.43.elf"

The default blobs are now newer.

@rpardini rpardini merged commit ab24a00 into armbian:main Jun 30, 2024
7 checks passed
@rpardini
Copy link
Member

@rpardini You can also consider removing the blobs on OPi 3B
and Odroid M1
The default blobs are now newer.

Should be addressed in #6837 -- thanks @ColorfulRhino !!!

@ColorfulRhino ColorfulRhino deleted the rk-blobs-bump branch July 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

2 participants