Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rootfs cache is repeating generation over and over again #6778

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jun 22, 2024

Description

In case we are changing rootfs cache content, we need to adjust cache name or rather have base cache package and add networking at image generation. This can be achieve with replacin add_packages_to_rootfs with add_packages_to_image.

Jira reference number AR-2384

How Has This Been Tested?

  • One manual test, the rest will be tested with CI

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jun 22, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug 08 Milestone: Third quarter release Build Executing build train (permission needed) and removed Framework Framework components labels Jun 22, 2024
@igorpecovnik igorpecovnik requested a review from a team as a code owner June 22, 2024 10:57
@github-actions github-actions bot added the Framework Framework components label Jun 22, 2024
… want to make caches for each variant

- also fixes a problem of generating caches all over again
- change cache date scheme name to force rebuild them all
@igorpecovnik igorpecovnik merged commit 8ccec18 into main Jun 22, 2024
142 of 143 checks passed
@igorpecovnik igorpecovnik deleted the AR-2384 branch June 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Build Executing build train (permission needed) Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

1 participant