Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate armbian.list if when==image-early #6087

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Don't generate armbian.list if when==image-early #6087

merged 1 commit into from
Dec 29, 2023

Conversation

adeepn
Copy link
Member

@adeepn adeepn commented Dec 25, 2023 •
edited by jira bot
Loading

Description

armbian.list generated two times on every build: when==image-early and when==image-late
If when==image-early armbian.list renamed to armbian.list.disabled and this file goes to image.

#6086

Jira reference number AR-2007

How Has This Been Tested?

  • Rebuild image, armbian.list.disabled disappears

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 25, 2023
@adeepn adeepn force-pushed the AR-2007-fix-armbian.list.disabled branch from 175032a to 9bb2e2d Compare December 25, 2023 12:50
@adeepn adeepn marked this pull request as ready for review December 25, 2023 12:50
@adeepn adeepn requested a review from a team as a code owner December 25, 2023 12:50
@adeepn adeepn added Bugfix Pull request is fixing a bug Needs review Seeking for review labels Dec 25, 2023
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 28, 2023
@adeepn adeepn merged commit 0b79ff3 into armbian:main Dec 29, 2023
@adeepn adeepn deleted the AR-2007-fix-armbian.list.disabled branch December 29, 2023 06:40
@adeepn adeepn mentioned this pull request Dec 29, 2023
Closed
1 task
@igorpecovnik igorpecovnik mentioned this pull request Dec 30, 2023
Closed
@viraniac viraniac mentioned this pull request Jan 1, 2024
Merged
7 tasks
igorpecovnik pushed a commit that referenced this pull request Jan 1, 2024
@viraniac
Fix rpi image creation broken since to #6087 (#6123)
fbad168 
* Revert "Don't generate armbian.list if when==image-early"
This reverts commit 0b79ff3.
* Remove armbian.list.disabled file if it exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeepn @igorpecovnik