Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression: LVM broken #7210

Closed
1 of 2 tasks
rvalle opened this issue Sep 11, 2024 · 3 comments
Closed
1 of 2 tasks

[Bug]: Regression: LVM broken #7210

rvalle opened this issue Sep 11, 2024 · 3 comments
Labels
Bug Something isn't working as it should

Comments

@rvalle
Copy link
Collaborator

rvalle commented Sep 11, 2024

What happened?

LVM builds are failing, cryptroot most probably too.

How to reproduce?

ENABLE_EXTENSIONS=lvm

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 22.04 Jammy

Are you building on Windows WSL2?

  • Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rvalle rvalle added the Bug Something isn't working as it should label Sep 11, 2024
Copy link

Jira ticket: AR-2489

@rvalle
Copy link
Collaborator Author

rvalle commented Sep 11, 2024

I have identified the main issue:

root_part_uuid="$(blkid -s UUID -o value ${LOOP}p${rootpart})"

the variable "rootdevice" should be used instead.
This is because extensions that transform the rootdevice may need to modify the root device.
fs-cryptoroot-support also modifies rootdevice, so this extension is probably broken too.
I am working on a fix.

@rvalle
Copy link
Collaborator Author

rvalle commented Sep 12, 2024

There is another issue with LVM volumes not being recognized mid-process, unless they are re-instantiated.

I suspect this issue has to do with the fact that I have updated my desktop Ubuntu version, and LVM subsystem is passed in to the docker image. In any case, re-instantiating cannot cause any possible harm.

rvalle pushed a commit to rvalle/armbian-build that referenced this issue Sep 12, 2024
rvalle pushed a commit to rvalle/armbian-build that referenced this issue Sep 12, 2024
rvalle pushed a commit to rvalle/armbian-build that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as it should
Development

No branches or pull requests

1 participant