Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise helpful error if IOWebApp fails to mount #346

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

gmkumar2005
Copy link
Contributor

Error messages during initialization will help beginners falling into trouble.

@gmkumar2005
Copy link
Contributor Author

With this change IOWebapp will throw an error if proper div is not found in the html which is used to load the scalajs application.
s"Unable to mount Calico. Check if $rootElementId exists in html")

@gmkumar2005
Copy link
Contributor Author

Fixed the error message.

@armanbilge armanbilge changed the title RaiseError in app initialization Raise helpful error if IOWebApp fails to mount Jan 29, 2024
Copy link
Owner

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I can't believe I left a raw map(_.get) there 😅

@armanbilge armanbilge merged commit 7703b48 into armanbilge:main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants