Use fs2.dom.Event[F] and friends
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not too bad! |
2chilled
reviewed
Jan 30, 2023
| @@ -146,37 +147,37 @@ private trait PropModifiers[F[_]](using F: Async[F]): | |||
| Modifier.forSignalResource[F, Any, OptionSignalResourceModifier[F, Any, Any], Option[Any]]( | |||
| _.values) { (m, n) => setPropOption(n, m.name, m.encode) } | |||
|
|
|||
| final class EventProp[F[_], E, A] private[calico] (key: String, pipe: Pipe[F, E, A]): | |||
| final class EventProp[F[_], A] private[calico] (key: String, pipe: Pipe[F, Any, A]): | |||
There was a problem hiding this comment.
Bye E, hope we don't miss you.
There was a problem hiding this comment.
Actually I think it wasn't needed even before, but I only realized when I did this PR.
There was a problem hiding this comment.
Yes, I think this is an orthogonal change. It would bother me because I like to pretend Any doesn't exist, but I see that we need that later on either way, because it helps us saving evil allocs ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
Eventand friends fs2-dom#51Admittedly, the codegen is a bit hacked, but meh 😅
The changes in #168 ended up being very helpful for this change, because now we actually need to map from
dom.Event => fs2.dom.Event[F].