Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix armada-airflow build #3624

Closed

Conversation

Sovietaced
Copy link
Contributor

… builds

Fixes #

Special notes for your reviewer:

@Sovietaced Sovietaced changed the title Update version of armada airflow so its compatible with python client… WIP: Fix armada-airflow build May 28, 2024
@richscott
Copy link
Member

@Sovietaced We expect that the new query API in Armada will be imminent, and the Airflow projects will be switching to using that, and will retire the old Job Service service. Likely this PR may be obsolete in the near future.

@Sovietaced
Copy link
Contributor Author

@Sovietaced We expect that the new query API in Armada will be imminent, and the Airflow projects will be switching to using that, and will retire the old Job Service service. Likely this PR may be obsolete in the near future.

This PR is about fixing the armada-airflow build. I don't think its related to the old jobs service at all. There has been a fix for the armada-airflow build here, but the approach is not ideal considering it locks users of armada-airflow to a specific version of grpcio. Libraries pinning dependencies is an anti pattern imo. Applications should pin dependencies, libraries should not.

@richscott
Copy link
Member

@Sovietaced our armada-airflow users have made a PR that indicates they are experiencing an incompatibility with the later versions of grpcio in using opentelemetry with airflow - see https://github.com/armadaproject/armada/pull/3631/files

@Sovietaced
Copy link
Contributor Author

@Sovietaced our armada-airflow users have made a PR that indicates they are experiencing an incompatibility with the later versions of grpcio in using opentelemetry with airflow - see #3631 (files)

Yes, I am aware: open-telemetry/opentelemetry-python#3931

@Sovietaced Sovietaced closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants