Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid generating nested currency options map #481

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

augustoccesar
Copy link
Contributor

@augustoccesar augustoccesar commented Jan 16, 2024

Summary

This PR adds a check to verify if the ty is already a CurrencyMap to avoid generating any nested Option<CurrencyMap<...>> as shown on #480 .

On a side note: this is something that will also be fixed on #452.

Closes #480
Closes #427

Checklist

@arlyon arlyon merged commit 99cb285 into arlyon:master Jan 24, 2024
16 checks passed
@arlyon
Copy link
Owner

arlyon commented Jan 24, 2024

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type for currency_options on UpdatePrice
2 participants