Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Fixed curve-bench compile error #83

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Nov 24, 2021

Description

Prior to this change, if you did cargo bench in curve-benches/ you'd get the error for all curves (not just BLS12-381)

error[E0433]: failed to resolve: could not find `VariableBaseMSM` in `msm`
  --> curve-benches/benches/bls12_381.rs:16:5
   |
16 |     ec_bench!(G1, G1Affine);
   |     ^^^^^^^^^^^^^^^^^^^^^^^ could not find `VariableBaseMSM` in `msm`
   |
   = note: this error originates in the macro `ec_bench` (in Nightly builds, run with -Z macro-backtrace for more info)

This change fixes the compile error.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmagician
Copy link
Member

I've patched ark-algebra-test-templates like I previously did here. There were some breaking changes since the last release (see here) and we need to use master of the algebra repo.

@mmagician mmagician merged commit c554790 into arkworks-rs:master Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants