Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertion and add test #759

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Remove assertion and add test #759

merged 2 commits into from
Jan 16, 2024

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Jan 16, 2024 •
edited
Loading

Description

Removed an assertion and added some testing for an edge case.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners January 16, 2024 14:59
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team January 16, 2024 14:59
@Pratyush Pratyush enabled auto-merge January 16, 2024 15:00
@mmagician
Copy link
Member

This should solve the fail in arkworks-rs/poly-commit#142, right? Or is there something else there broken?

@Pratyush
Copy link
Member Author

Yup it should.

mmagician
mmagician approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is better yes

@Pratyush Pratyush added this pull request to the merge queue Jan 16, 2024
Merged via the queue into master with commit bf96a5b Jan 16, 2024
38 checks passed
@Pratyush Pratyush deleted the fix-batch-mul branch January 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmagician mmagician mmagician approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pratyush @mmagician