Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CyclotomicField to represent cyclotomic operations #446

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Aug 1, 2022

Description

Another part of #294


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

ff/src/fields/mod.rs Outdated Show resolved Hide resolved
@mmagician
Copy link
Member

Adding (doc?) examples for using square from Field & cyclotomic_square would further help to avoid confusion.

@Pratyush Pratyush force-pushed the impl-cyclotomic-field branch from 1faf496 to 4af3f62 Compare August 12, 2022 18:27
@Pratyush Pratyush requested a review from mmagician August 12, 2022 18:38
@Pratyush Pratyush mentioned this pull request Aug 12, 2022
6 tasks
@Pratyush Pratyush force-pushed the impl-cyclotomic-field branch from 4af3f62 to dd3bbea Compare August 13, 2022 03:22
@Pratyush Pratyush force-pushed the impl-cyclotomic-field branch from eed28f9 to 02eed57 Compare August 15, 2022 19:28
@Pratyush Pratyush merged commit d289199 into master Aug 18, 2022
@Pratyush Pratyush deleted the impl-cyclotomic-field branch August 18, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants