Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Allow rxjs v7 in angular 12 projects #181

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

jasonkenneth
Copy link
Contributor

@jasonkenneth jasonkenneth commented Nov 2, 2021

Even though Angular 12 shipped with rxjs v6, they made changes to support v7.

angular/angular#41897
angular/angular#42991
https://github.com/angular/angular/blob/fd1e7d4f0d73df42422caa056957aeaad2944a4a/packages/core/package.json#L19

When running npm install in an Angular 12 project with rxjs v7x, we get the following error.

npm ERR! Found: rxjs@7.4.0
npm ERR! node_modules/rxjs
npm ERR!   rxjs@"7.4.0" from the root project
npm ERR!   peer rxjs@"^6.5.3 || ^7.0.0" from @angular/common@12.2.12
npm ERR!   node_modules/@angular/common
npm ERR!     @angular/common@"12.2.12" from the root project
npm ERR!     peer @angular/common@"^12.0.0" from ng-inline-svg@13.1.0
npm ERR!     node_modules/ng-inline-svg
npm ERR!       ng-inline-svg@"13.1.0" from the root project
npm ERR!   1 more (@angular/core)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^6.6.0" from ng-inline-svg@13.1.0
npm ERR! node_modules/ng-inline-svg
npm ERR!   ng-inline-svg@"13.1.0" from the root project

@jasonkenneth jasonkenneth changed the title Allow rxjs v7 in angular 12 Allow rxjs v7 in angular 12 projects Nov 2, 2021
@arkon arkon merged commit 7b3d70c into arkon:master Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants