This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Adding fallbackSVG Input #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hello @arkon , |
|
Thanks for the contribution! |
|
It was a pleasure 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
Using this library within my company project, we had to generate the SVG file based on some data received from the backend.
In case of no corresponding SVG is present we handle it by defining the output onSVGFailed and we just switch the inlineSVG input with our fallbackSVG.
For this reason, I created this PR, in order to have the possibility to provide a fallbackSVG without handle it with the onSVGFailed output.
Have a nice day :)