fix: infromational issues (#332)

* fix: error registration

* fix: service lookups

* chore: remove redundant validations and code improvements

* chore: update changelog

* chore: update build flag

CHANGELOG.md

@@ -47,6 +47,7 @@ Contains all the PRs that improved the code without changing the behaviors.
 - Fixed non deterministic map iteration to sorted iteration 
 - Fixed fee stuck in arkeo module by moving fees to arkeo-reserve
 - Fixed signature replay on different network
+- Fixed informational issues
 
 ---
 

common/service.go

@@ -53,6 +53,7 @@ var ServiceLookup = map[string]int32{
 	"thorchain-mainnet-fullnode":   32,
 	"bch-mainnet-unchained":        33,
 	"btc-mainnet-unchained":        34,
+	"bnb-mainnet-unchained":        35,
 	"bsc-mainnet-unchained":        36,
 	"gaia-mainnet-unchained":       38,
 	"doge-mainnet-unchained":       39,
@@ -107,7 +108,6 @@ var ServiceReverseLookup = map[Service]string{
 	34: "btc-mainnet-unchained",
 	35: "bnb-mainnet-unchained",
 	36: "bsc-mainnet-unchained",
-	37: "bsc-mainnet-unchained",
 	38: "gaia-mainnet-unchained",
 	39: "doge-mainnet-unchained",
 	40: "eth-mainnet-unchained",

x/arkeo/keeper/manager.go

@@ -256,10 +256,6 @@ func (mgr Manager) ValidatorPayout(ctx cosmos.Context, votes []abci.VoteInfo, bl
 			mgr.keeper.Logger().Info("unable to find validator", "validator", string(vote.Validator.Address))
 			continue
 		}
-		if !val.IsBonded() || val.IsJailed() {
-			mgr.keeper.Logger().Info("validator rewards skipped due to status or jailed", "validator", val.GetOperator())
-			continue
-		}
 
 		valBz, err := mgr.sk.ValidatorAddressCodec().StringToBytes(val.GetOperator())
 		if err != nil {

x/arkeo/keeper/msg_server_close_contract.go

@@ -53,9 +53,9 @@ func (k msgServer) CloseContractValidate(ctx cosmos.Context, msg *types.MsgClose
 		return errors.Wrapf(types.ErrInvalidPubKey, "Cleint: %s", contract.Client.String())
 	}
 
-	signerAddreess := msg.MustGetSigner()
+	signerAddress := msg.MustGetSigner()
 
-	if !contractClientAddress.Equals(signerAddreess) {
+	if !contractClientAddress.Equals(signerAddress) {
 		return errors.Wrap(types.ErrCloseContractUnauthorized, "only the client can close the contract")
 	}
 
@@ -78,17 +78,6 @@ func (k msgServer) CloseContractHandle(ctx cosmos.Context, msg *types.MsgCloseCo
 		return err
 	}
 
-	contractClientAddress, err := contract.Client.GetMyAddress()
-	if err != nil {
-		return errors.Wrapf(types.ErrInvalidPubKey, "Cleint: %s", contract.Client.String())
-	}
-
-	signerAddreess := msg.MustGetSigner()
-
-	if !contractClientAddress.Equals(signerAddreess) {
-		return errors.Wrap(types.ErrCloseContractUnauthorized, "only the client can close the contract")
-	}
-
 	if contract.IsPayAsYouGo() {
 		k.RemoveContractExpirationSet(ctx, contract.Expiration())
 		// add a new expiration return deposit to user

x/arkeo/keeper/msg_server_open_contract.go

@@ -92,7 +92,7 @@ func (k msgServer) OpenContractValidate(ctx cosmos.Context, msg *types.MsgOpenCo
 			return errors.Wrapf(types.ErrOpenContractMismatchRate, "provider rates is %d, client sent %d", cosmos.NewCoins(provider.SubscriptionRate...).AmountOf(msg.Rate.Denom).Int64(), msg.Rate.Amount.Int64())
 		}
 		if !cosmos.NewInt(msg.Rate.Amount.Int64() * msg.Duration * msg.QueriesPerMinute).Equal(msg.Deposit) {
-			return errors.Wrapf(types.ErrOpenContractMismatchRate, "mismatch of rate*duration and deposit: %d * %d * %d != %d", msg.Rate.Amount.Int64(), msg.Duration, msg.QueriesPerMinute, msg.Deposit.Int64())
+			return errors.Wrapf(types.ErrOpenContractMismatchRate, "mismatch of rate*duration*queriesPerMinute and deposit: %d * %d * %d != %d", msg.Rate.Amount.Int64(), msg.Duration, msg.QueriesPerMinute, msg.Deposit.Int64())
 		}
 	case types.ContractType_PAY_AS_YOU_GO:
 		if cosmos.NewCoins(provider.PayAsYouGoRate...).AmountOf(msg.Rate.Denom).IsZero() {

x/arkeo/types/message_mod_provider.go

@@ -112,7 +112,7 @@ func (msg *MsgModProvider) ValidateBasic() error {
 
 	payRate := cosmos.NewCoins(msg.PayAsYouGoRate...)
 	if err := payRate.Validate(); err != nil {
-		return errors.Wrapf(err, "invalid subscription rate")
+		return errors.Wrapf(err, "invalid pay-as-you-go rates")
 	}
 
 	if !payRate.IsAllPositive() {

x/claim/keeper/msg_server_add_claim.go

@@ -1,5 +1,3 @@
-//go:build !testnet
-
 package keeper
 
 import (

x/claim/types/errors.go

@@ -5,10 +5,10 @@ import (
 )
 
 var (
-	ErrAirdropEnded                = errors.Register(ModuleName, 1, "Airdrop has ended")
-	ErrNoClaimableAmount           = errors.Register(ModuleName, 2, "No Claimable Arkeo")
-	ErrInvalidSignature            = errors.Register(ModuleName, 3, "Invalid signature")
-	ErrClaimRecordNotTransferrable = errors.Register(ModuleName, 4, "Claim record can not be transferred")
-	ErrInvalidCreator              = errors.Register(ModuleName, 5, "Invalid Creator")
-	ErrInvalidAddress              = errors.Register(ModuleName, 6, "Invalid Address")
+	ErrAirdropEnded                = errors.Register(ModuleName, 2, "Airdrop has ended")
+	ErrNoClaimableAmount           = errors.Register(ModuleName, 3, "No Claimable Arkeo")
+	ErrInvalidSignature            = errors.Register(ModuleName, 4, "Invalid signature")
+	ErrClaimRecordNotTransferrable = errors.Register(ModuleName, 5, "Claim record can not be transferred")
+	ErrInvalidCreator              = errors.Register(ModuleName, 6, "Invalid Creator")
+	ErrInvalidAddress              = errors.Register(ModuleName, 7, "Invalid Address")
 )